Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import QAWolf test file #1643

Merged
merged 3 commits into from
Aug 6, 2024
Merged

fix: import QAWolf test file #1643

merged 3 commits into from
Aug 6, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

@AyushAgrawal-A2 AyushAgrawal-A2 commented Aug 3, 2024

ref: https://quadratichq.slack.com/archives/C06Q34HGV8A/p1722640177200679

From QA Wolf

Description:
Steps to reproduce:

  1. Login
  2. Click "Create file" button in top right | Click "Import file" dropdown and select Quadratic (.grid) file type
    Expected: After creating a file, a new sheet titled "Untitled" is opened. After importing a sheet, the imported sheet is opened in >a new spreadsheet with the title as the file name.
    Actual: Files cannot be created. When clicking "Create file" button - error message at the bottom "Failed to create file. Try >again." When importing a file, no error message, however error in console.
    Video:
    https://www.loom.com/share/494c5cd6b9e8468098f18545b49eccb2?sid=5355cc10-67ab-4819-bc13-90ded338a144
    Priority:
    Unprioritized

Fixes import of QAWolf test file, which has schema 1.5 code runs.

Copy link

qa-wolf bot commented Aug 3, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Aug 3, 2024
Copy link

vercel bot commented Aug 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Aug 5, 2024 11:07pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1643 August 3, 2024 05:31 Inactive
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (83fb591) to head (e0e452c).
Report is 18 commits behind head on qa.

Files Patch % Lines
quadratic-core/src/grid/file/v1_5/file.rs 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #1643      +/-   ##
==========================================
+ Coverage   89.88%   90.18%   +0.29%     
==========================================
  Files         191      191              
  Lines       36759    36784      +25     
==========================================
+ Hits        33041    33172     +131     
+ Misses       3718     3612     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1643 August 5, 2024 22:38 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1643 August 5, 2024 22:39 Inactive
@AyushAgrawal-A2
Copy link
Collaborator Author

for remaining code cov, I'll have to make it panic

image

Copy link
Collaborator

@ddimaria ddimaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition 🙌

@davidkircos davidkircos merged commit d8f1191 into qa Aug 6, 2024
13 of 14 checks passed
@davidkircos davidkircos deleted the ayush/fix_import_file branch August 6, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants