Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jump to axis on Cmd + (Shift)? + Arrow keys #1627

Merged
merged 5 commits into from
Jul 31, 2024
Merged

jump to axis on Cmd + (Shift)? + Arrow keys #1627

merged 5 commits into from
Jul 31, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

closes #1626

Copy link

qa-wolf bot commented Jul 30, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Jul 31, 2024 1:09am

@cla-bot cla-bot bot added the cla-signed label Jul 30, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1627 July 30, 2024 20:45 Inactive
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.82%. Comparing base (0cbf5c2) to head (8ec893b).

Files Patch % Lines
quadratic-core/src/grid/sheet/bounds.rs 96.61% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #1627   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files         185      185           
  Lines       35092    35094    +2     
=======================================
+ Hits        31520    31523    +3     
+ Misses       3572     3571    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1627 July 30, 2024 20:59 Inactive
Copy link
Collaborator

@ddimaria ddimaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust code looks good!

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1627 July 30, 2024 21:07 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1627 July 31, 2024 00:12 Inactive
@AyushAgrawal-A2 AyushAgrawal-A2 changed the title jump to 0th col / row on Cmd + (Shift)? + Arrow keys jump to axis on Cmd + (Shift)? + Arrow keys Jul 31, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1627 July 31, 2024 00:42 Inactive
@davidkircos davidkircos merged commit 2f4af34 into qa Jul 31, 2024
14 checks passed
@davidkircos davidkircos deleted the ayush/1626 branch July 31, 2024 20:05
Copy link

qa-wolf bot commented Jul 31, 2024

E2E tests

QA No blocking bugs

Ran Status Preview Started Run time Est. dev time saved
63 workflows Done (Details) Jul 31, 2024 at 8:21 PM (UTC) 6 minutes ~27.83 hrs
✅ 58 passed

Preexisting bugs

0 Blocking bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

2 Non-blocking bugs

. . . . . . . .

Re-run your E2E tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jump to beginning of column or row with cmd+arrowkeys
3 participants