This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Update shovel UI for AMQP 1.0 shovels #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow cross protocol shovels to be created and managed through the UI. To get the desired layout I had to do a fair bit of mangling of the sammy parameters before the PUT request. To allow configuration of different protocols I had to prefix the input fields with the protocol and direction and later strip the prefixes and remove the unwanted properties. A better approach to this shoudl be found if further protocols are implemented. [#138600475]
dcorbacho
reviewed
May 30, 2017
| <td> | ||
| <label class="wide"> | ||
| Address: | ||
| <span class="help" id="shovel-amqp10-address"></span> |
There was a problem hiding this comment.
Help shovel-amqp10-address is not defined
priv/www/js/tmpl/dynamic-shovels.ejs
Outdated
| <td> | ||
| <label> | ||
| Auto-delete | ||
| <span class="help" id="shovel-delete-after"></span> |
There was a problem hiding this comment.
The tag on the help message (After initial length transferred) differs from the value shown After num messages. For clarity, the tag should be the same or an abbreviation of it.
Use values provided by rabbit_shovel_status directly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: rabbitmq/rabbitmq-shovel#26