[ABW-3213] Address Details

[matiasbzurovski]

Jira ticket: ABW-3213
Jira ticket: ABW-3256

Description

This PR adds a sheet presented every time the user taps on an AddressView with a LedgerIdentifiable.Address associated.

Video

demo.mov

[matiasbzurovski]

Ended up not being used on these designs but decided to keep it as we will probably need it somewhere else (it is part of the design system.

[kugel3]

I think this should be either a local private function, or, if you might want to use it somewhere else, a var on LedgerIdentifiable.Address or something.

[matiasbzurovski]

The idea was to computate it only once

[kugel3]

The ViewState is actually re-computed every time anything changes, as is the entire SwiftUI View, so I don't think it makes any difference.

But either way, my idea was just to change the ergonomics to something like this:

let addressString = address.colorizedString

It might be that Observable is smart enough to only recompute it when the underlying address changes if you do it like that. When it's in the ViewState, any change to any property on the ViewState would recompute everything.

Seems like it could be useful more generally, btw.

[kugel3]

Looks good, just some minor suggestions

[kugel3]

You can add @Reducer to this. Then you need to also put public typealias Action = FeatureAction<Self> explicitly, otherwise the compiler gets confused.

[matiasbzurovski]

and what's the benefit of doing so if we still need to implement every func reduce we currently have?

[kugel3]

It's usually good to stay up to date with the latest generation of TCA, so we can enjoy any future improvements coming to @Reducer they make.

[kugel3]

Now the dismiss doesn't actually work for me in your PR. But putting@Environment(\.dismiss) var dismiss in the View instead does work.

[GhenadieVP]

LGTM!

[GhenadieVP]

should this rather be:

await store.send(.view(.task)).finish()

to allow proper cancellation