-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-3213] Address Details #1100
Merged
Merged
Changes from 40 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
fd6ecfb
WIP
matiasbzurovski 43419d8
Create new AccountAddressView and update AddressView logic
matiasbzurovski 135a774
everyone is a @MainActor
matiasbzurovski 6d1d3f3
More components added to AccountAddressView
matiasbzurovski b003a5a
Add brand1 gradient
matiasbzurovski ddb54f4
Add gradient address
matiasbzurovski 911c379
Use gray2 on iOS 16
matiasbzurovski afcad87
Remove long pressure from AddressView
matiasbzurovski 5fc8cdf
Support for copy and share actions
matiasbzurovski ab12311
Add enlarged view
matiasbzurovski d1384be
Renamed AddressDetailView
matiasbzurovski 963712f
Allow verification of account on ledger
matiasbzurovski f26657f
Load title
matiasbzurovski 0912921
use correct title for resources
matiasbzurovski b24bcfa
Adapt padding and spacing
matiasbzurovski 4f6b82a
lint
matiasbzurovski 379bdff
Final details
matiasbzurovski 1e7f83f
Get hidden part only
matiasbzurovski 4e26429
Get middle of address from Sargon
matiasbzurovski 73c1481
Update Sargon dependency
matiasbzurovski 1dfd025
Using Reducer
matiasbzurovski 6e2e28f
Merge branch 'main' into ABW-3213
matiasbzurovski 5730aad
Use localisation strings
matiasbzurovski 7152057
Use always the copy icon on AddressView
matiasbzurovski fe5859d
Use Address.nonFungibleGlobalId for NFTs (pending fix on colorisation)
matiasbzurovski 3b68253
Show compacted text on non fungible global id
matiasbzurovski 32a0001
Remove LedgerIdentifiable.identifier and have .transaction instead
matiasbzurovski 427f39d
Merge branch 'main' into ABW-3213
matiasbzurovski 17aea33
Fixes after merge
matiasbzurovski 00dd73b
Merge branch 'main' into ABW-3213
matiasbzurovski a9b6ce2
Update Account preferences to show card
matiasbzurovski 099b43f
Remove unused logic from AccountPreferences
matiasbzurovski 8b64e2e
Merge branch 'main' into ABW-3213
matiasbzurovski 25aab9a
Merge branch 'main' into ABW-3213
matiasbzurovski ce6f16d
Merge branch 'main' into ABW-3213
matiasbzurovski b320e53
Fix for global ids
matiasbzurovski ed733f0
Compute only once
matiasbzurovski d6de04e
Simplify dismiss
matiasbzurovski 0a2a19b
Changes after feedback
matiasbzurovski 033ccd5
Use observable
matiasbzurovski 452be2c
Last fixes
matiasbzurovski 4801e6b
Merge branch 'main' into ABW-3213
matiasbzurovski 48e4eaa
Sargon
matiasbzurovski 7516f98
Show local part for NFT ids
matiasbzurovski 3a29de0
Merge branch 'main' into ABW-3213
matiasbzurovski f1e0ce4
Fix colorised text for Global ids whose local id was part of the reso…
matiasbzurovski 33b49b7
Final changes
matiasbzurovski 130a2cd
await task
matiasbzurovski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
extension Text { | ||
@_disfavoredOverload | ||
init?(_ content: (some StringProtocol)?) { | ||
guard let content else { | ||
return nil | ||
} | ||
self.init(content) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ended up not being used on these designs but decided to keep it as we will probably need it somewhere else (it is part of the design system.