-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sargon os v1 #1234
Draft
GhenadieVP
wants to merge
10
commits into
main
Choose a base branch
from
sargon_os_v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Sargon os v1 #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t however you like. IT IS NOT IMPORTANT data passed to creation of DeviceFactorSources.
Base automatically changed from
sargon_os_ensure_no_non_trivial_breaking_change
to
main
July 30, 2024 14:33
CyonAlexRDX
reviewed
Aug 9, 2024
let factorSource = switch onDeviceMnemonicKind { | ||
case let .babylon(isMain): | ||
DeviceFactorSource.babylon( | ||
mnemonicWithPassphrase: mnemonicWithPassphrase, | ||
isMain: isMain | ||
isMain: isMain, | ||
deviceInfo: deviceInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this not changed to be named to hostInfo
.
I think a merge main into Sargon, and update iOS host code is needed? Would make review easier :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough draft for Sargon OS v1