Sargon os v1 #1234
Draft
Sargon os v1 #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t however you like. IT IS NOT IMPORTANT data passed to creation of DeviceFactorSources.
Base automatically changed from
sargon_os_ensure_no_non_trivial_breaking_change
to
main
July 30, 2024 14:33
CyonAlexRDX
reviewed
Aug 9, 2024
| let factorSource = switch onDeviceMnemonicKind { | ||
| case let .babylon(isMain): | ||
| DeviceFactorSource.babylon( | ||
| mnemonicWithPassphrase: mnemonicWithPassphrase, | ||
| isMain: isMain | ||
| isMain: isMain, | ||
| deviceInfo: deviceInfo |
There was a problem hiding this comment.
Was this not changed to be named to hostInfo.
I think a merge main into Sargon, and update iOS host code is needed? Would make review easier :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough draft for Sargon OS v1