Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SargonOS v1 integration API #184

Merged
merged 15 commits into from
Aug 12, 2024
Merged

SargonOS v1 integration API #184

merged 15 commits into from
Aug 12, 2024

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Jul 11, 2024

Implements SargonOS V1:

This iOS Wallet PR - radixdlt/babylon-wallet-ios#1234 - roughly showcases how the V1 integration would look like.

Note - this PR also contains the Android PR -> #196;
This commit shows the changes that were made to facilitate V1.

CyonAlexRDX and others added 6 commits June 28, 2024 15:16
…(working example app)! (#131)

Introducing SargonOS
MFA Batch 1: SecurityStructureOfFactorSources and MatrixOfFactorSoures and also on FactorSourceID and FactorInstance level. Also add some new FactorSourceKinds at least a POC version of them or stubbed out ones.
Revert Profile JSON format changes in DeviceInfo
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 92.12963% with 17 lines in your changes missing coverage. Please review.

Project coverage is 97.5%. Comparing base (e8cb924) to head (5e05d00).

Files Patch % Lines
apple/Sources/Sargon/Util/EventPublisher.swift 33.3% 4 Missing ⚠️
...torage/key/DeviceFactorSourceMnemonicKeyMapping.kt 86.9% 2 Missing and 1 partial ⚠️
...radixdlt/sargon/os/storage/key/HostIdKeyMapping.kt 90.9% 2 Missing and 1 partial ⚠️
...ixdlt/sargon/os/storage/key/ByteArrayKeyMapping.kt 95.0% 0 Missing and 2 partials ⚠️
...ain/java/com/radixdlt/sargon/os/storage/KeySpec.kt 87.5% 1 Missing ⚠️
...ava/com/radixdlt/sargon/os/storage/StorageUtils.kt 95.6% 0 Missing and 1 partial ⚠️
...sargon/os/storage/key/ProfileSnapshotKeyMapping.kt 94.4% 0 Missing and 1 partial ⚠️
...ent/secure_storage_client/secure_storage_client.rs 87.5% 1 Missing ⚠️
src/system/sargon_os/sargon_os_profile.rs 93.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #184   +/-   ##
=====================================
  Coverage   97.4%   97.5%           
=====================================
  Files        908     912    +4     
  Lines      14497   14533   +36     
  Branches      38      63   +25     
=====================================
+ Hits       14127   14174   +47     
+ Misses       364     351   -13     
- Partials       6       8    +2     
Flag Coverage Δ
kotlin 98.6% <93.5%> (+2.0%) ⬆️
rust 97.0% <93.9%> (-0.1%) ⬇️
swift 99.3% <66.6%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...n/Drivers/HostInfo/HostInfoDriver+DeviceInfo.swift 96.2% <ø> (ø)
...s/Sargon/Drivers/ProfileChange/ProfileChange.swift 100.0% <100.0%> (ø)
...Swiftified/System/Drivers/Drivers+Swiftified.swift 100.0% <100.0%> (ø)
...ple/Sources/Sargon/SargonOS/SargonOSProtocol.swift 100.0% <ø> (ø)
.../java/com/radixdlt/sargon/extensions/BagOfBytes.kt 100.0% <100.0%> (ø)
.../java/com/radixdlt/sargon/extensions/Decimal192.kt 98.3% <ø> (-0.3%) ⬇️
...ava/com/radixdlt/sargon/extensions/FactorSource.kt 100.0% <100.0%> (+16.6%) ⬆️
...main/java/com/radixdlt/sargon/extensions/Result.kt 100.0% <100.0%> (ø)
...com/radixdlt/sargon/extensions/UnsafeStorageKey.kt 100.0% <100.0%> (ø)
...rgon/os/radixconnect/RadixConnectSessionStorage.kt 100.0% <100.0%> (ø)
... and 16 more

... and 7 files with indirect coverage changes

micbakos-rdx and others added 4 commits July 15, 2024 14:32
* Implement HostInfo struct

* Store host id in secure storage

* Fix doc

* Separate id and date from host info

* Implement HostOS that will encapsulate the different values and constants of each host os

* Expose uniffi method for creating device info from host info
Base automatically changed from sargon_os to main July 29, 2024 14:31
micbakos-rdx and others added 2 commits August 7, 2024 16:16
* Implement sargon os drivers

* Boot sargon os in example app

* Remove active profile id

* Add more unit tests

* Fix apple tests
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single actor Swift side is proabably preferable:

498f627#r1711241760

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GhenadieVP GhenadieVP merged commit 5d45750 into main Aug 12, 2024
10 checks passed
@GhenadieVP GhenadieVP deleted the sargon_os_v1 branch August 12, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants