-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SargonOS v1 integration API #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(working example app)! (#131) Introducing SargonOS
MFA Batch 1: SecurityStructureOfFactorSources and MatrixOfFactorSoures and also on FactorSourceID and FactorInstance level. Also add some new FactorSourceKinds at least a POC version of them or stubbed out ones.
Revert Profile JSON format changes in DeviceInfo
* Implement HostInfo struct * Store host id in secure storage * Fix doc * Separate id and date from host info * Implement HostOS that will encapsulate the different values and constants of each host os * Expose uniffi method for creating device info from host info
micbakos-rdx
force-pushed
the
sargon_os_v1
branch
from
July 25, 2024 13:37
ac15df4
to
498f627
Compare
* Implement sargon os drivers * Boot sargon os in example app * Remove active profile id * Add more unit tests * Fix apple tests
GhenadieVP
commented
Aug 9, 2024
src/system/clients/client/profile_change_client/profile_change_client.rs
Show resolved
Hide resolved
GhenadieVP
commented
Aug 9, 2024
GhenadieVP
commented
Aug 9, 2024
GhenadieVP
commented
Aug 9, 2024
GhenadieVP
commented
Aug 9, 2024
CyonAlexRDX
reviewed
Aug 9, 2024
CyonAlexRDX
reviewed
Aug 9, 2024
src/system/drivers/profile_change_driver/support/test/rust_profile_change_driver.rs
Show resolved
Hide resolved
CyonAlexRDX
reviewed
Aug 9, 2024
CyonAlexRDX
reviewed
Aug 9, 2024
CyonAlexRDX
reviewed
Aug 9, 2024
CyonAlexRDX
reviewed
Aug 9, 2024
CyonAlexRDX
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single actor Swift side is proabably preferable:
CyonAlexRDX
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements SargonOS V1:
This iOS Wallet PR - radixdlt/babylon-wallet-ios#1234 - roughly showcases how the V1 integration would look like.
Note - this PR also contains the Android PR -> #196;
This commit shows the changes that were made to facilitate V1.