Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3650] Security state incorrectly updating #1235

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Jul 23, 2024

Jira ticket: ABW-3650

Description

This PR solves an issue where a security problem would up for an instant when toggling the balances visibility.

Notes

This issue was introduced when we fixed another similar on #1207. Basically, we were considering .started backups as failures, which helped solved the previous situation.
However, we shouldn't consider .started backups as failures when the last backup was a .success: they should only be considered failures when the previous one was a .failure. Therefore, the solution is to just ignore .started backups for this check.

Before vs After

Before After
before.mov
after.mov

@GhenadieVP
Copy link
Contributor

GhenadieVP commented Jul 24, 2024

To understand these issues better,
it seems that this removal is the root cause that triggers those inconsistencies. It feels a bit odd to end up in the state of no backup when because backup info is removed right before another backup is started, shouldn't the old backup info be rather replaced than removed and then added again 🤔?

@matiasbzurovski
Copy link
Contributor Author

@GhenadieVP not really, the removal is only done if the latest backup failed. For the case this PR fixes, no backup has failed and we still had this issue because a backup was set as .started and we considered that an error.

@GhenadieVP GhenadieVP merged commit 4ce9251 into main Jul 25, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the ABW-3650-security-problem branch July 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants