[ABW-3650] Security state incorrectly updating #1235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3650
Description
This PR solves an issue where a security problem would up for an instant when toggling the balances visibility.
Notes
This issue was introduced when we fixed another similar on #1207. Basically, we were considering
.started
backups as failures, which helped solved the previous situation.However, we shouldn't consider
.started
backups as failures when the last backup was a.success
: they should only be considered failures when the previous one was a.failure
. Therefore, the solution is to just ignore.started
backups for this check.Before vs After
before.mov
after.mov