Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3650] Security state incorrectly updating #1235

Merged
merged 1 commit into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ extension SecurityCenterClient {
func cloudBackups() async -> AnyAsyncSequence<BackupStatus?> {
let profileID = await profileStore.profile.id
let backups = userDefaults.lastCloudBackupValues(for: profileID)
.filter { backup in
backup?.isFinal ?? true
}
.eraseToAnyAsyncSequence()
return await statusValues(results: backups)
}

Expand Down Expand Up @@ -72,8 +76,7 @@ extension SecurityCenterClient {
guard let cloudBackup = backups.cloud else {
return true
}

return !cloudBackup.result.succeeded
return cloudBackup.result.failed
}

func hasProblem6() -> Bool {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,13 @@ public struct BackupResult: Hashable, Codable, Sendable {
}
}

public var isFinal: Bool {
switch result {
case .started: false
case .failure, .success: true
}
}

public enum Result: Hashable, Codable, Sendable {
case started(Date)
case success
Expand Down
Loading