Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABW-3719 Warn When Linking New Accounts #1282

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Aug 12, 2024

Jira ticket: ABW-3719

Description

Adds the warning shown in the screenshot, when a fee payer is selected that wouldn't otherwise be part of the transaction. Also refactors the warning logic, along the lines described here.

How to test

  1. Create three accounts, A, B and C
  2. Put some XRD in at least A and C
  3. Make a transfer from A to B
  4. Select C as fee payer for the transaction
    -> The warning should be shown, as per the screenshot

Screenshot

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@kugel3 kugel3 changed the title ABW-3719 Warn when linking new accounts ABW-3719 Warn When Linking New Accounts Aug 12, 2024
@kugel3 kugel3 force-pushed the ABW-3719_Warn-new-accounts-og branch 2 times, most recently from e15eb4d to 2549b98 Compare August 14, 2024 10:25
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@danvleju-rdx danvleju-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kugel3 kugel3 mentioned this pull request Aug 14, 2024
1 task
@kugel3 kugel3 changed the base branch from main to revert-premature-changes August 14, 2024 12:05
@kugel3 kugel3 force-pushed the ABW-3719_Warn-new-accounts-og branch from 2549b98 to 070d196 Compare August 14, 2024 12:07
Base automatically changed from revert-premature-changes to main August 14, 2024 12:57
@kugel3 kugel3 merged commit 9d17702 into main Aug 14, 2024
6 checks passed
@kugel3 kugel3 deleted the ABW-3719_Warn-new-accounts-og branch August 14, 2024 12:58
@kugel3 kugel3 restored the ABW-3719_Warn-new-accounts-og branch August 20, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants