-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABW-3719 Warn When Linking New Accounts #1282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
changed the title
ABW-3719 Warn when linking new accounts
ABW-3719 Warn When Linking New Accounts
Aug 12, 2024
kugel3
force-pushed
the
ABW-3719_Warn-new-accounts-og
branch
2 times, most recently
from
August 14, 2024 10:25
e15eb4d
to
2549b98
Compare
CyonAlexRDX
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
danvleju-rdx
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kugel3
force-pushed
the
ABW-3719_Warn-new-accounts-og
branch
from
August 14, 2024 12:07
2549b98
to
070d196
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3719
Description
Adds the warning shown in the screenshot, when a fee payer is selected that wouldn't otherwise be part of the transaction. Also refactors the warning logic, along the lines described here.
How to test
-> The warning should be shown, as per the screenshot
Screenshot
PR submission checklist