Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABW-3719 Warn When Linking New Accounts (again) #1288

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Aug 20, 2024

Jira ticket: ABW-3719

Description

(Apparently all changes were lost when GitHub changed the branch for the previous PR)

Adds the warning shown in the screenshot, when a fee payer is selected that wouldn't otherwise be part of the transaction. Also refactors the warning logic, along the lines described here.

How to test

  1. Create three accounts, A, B and C
  2. Put some XRD in at least A and C
  3. Make a transfer from A to B
  4. Select C as fee payer for the transaction
    -> The warning should be shown, as per the screenshot

Screenshot

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@kugel3 kugel3 merged commit f69fef0 into main Aug 20, 2024
6 checks passed
@kugel3 kugel3 deleted the ABW-3719_Warn-new-accounts-og branch August 20, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants