Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-3743] Show fiat value of Transaction fees #1292

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[ABW-3743] Show fiat value of Transaction fees #1292

merged 1 commit into from
Aug 22, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Aug 21, 2024 •
edited by jira bot
Loading

Jira ticket: ABW-3743

Description

Shows the fiat value of transaction fees.

Screenshot

CyonAlexRDX
CyonAlexRDX approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

I was abit surprised that we hade to pass the currency to the price client - I would have expected it to read currency from profile already.

Perhaps worth a small refactor ?

@matiasbzurovski matiasbzurovski merged commit e6e0af1 into main Aug 22, 2024
6 checks passed
@matiasbzurovski matiasbzurovski deleted the ABW-3743-fee-usd branch August 22, 2024 10:45
@matiasbzurovski matiasbzurovski mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasbzurovski @CyonAlexRDX