[ABW-3750] Fix infinite loading on fiat price after updating TX fee #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
reviewed
Aug 22, 2024
| @@ -66,7 +66,7 @@ extension TransactionReviewNetworkFee { | |||
| .foregroundColor(.app.blue2) | |||
| } | |||
| } | |||
| .task { | |||
| .task(id: viewStore.id) { | |||
| viewStore.send(.task) | |||
There was a problem hiding this comment.
should we not call finish on the send btw?
There was a problem hiding this comment.
I don't think so, since the view is able to show up while the task takes place (token price is fetched).
GhenadieVP
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3750
Description
This PR fixes an issue introduced in #1292, where the fiat value for the price would show an infinite loading spinner after updating such price.
Video
demo.txn.fee.usd.fix.mov