ABW-1671 Info Buttons and Sheet #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
force-pushed
the
ABW-1671_Info-sheet
branch
from
734b11a
to
de41e79
Compare
CyonAlexRDX
reviewed
Aug 26, 2024
RadixWallet/Features/AssetsFeature/Components/HelperViews/EmptyAssetListView.swift
Show resolved
Hide resolved
GhenadieVP
reviewed
Aug 26, 2024
GhenadieVP
reviewed
Aug 26, 2024
RadixWallet/Clients/OverlayWindowClient/OverlayWindowClient+Interface.swift
Outdated
Show resolved
Hide resolved
kugel3
force-pushed
the
ABW-1671_Info-sheet
branch
from
6a51819
to
89f543d
Compare
kugel3
force-pushed
the
ABW-1671_Info-sheet
branch
from
dcb9f14
to
6f8960a
Compare
kugel3
force-pushed
the
ABW-1671_Info-sheet
branch
from
7bd27fb
to
deb8461
Compare
GhenadieVP
reviewed
Aug 28, 2024
RadixWallet/Clients/OverlayWindowClient/OverlayWindowClient+Interface.swift
Outdated
Show resolved
Hide resolved
matiasbzurovski
approved these changes
Aug 28, 2024
RadixWallet/Features/AppFeature/Overlay/FullScreenOverlayCoordinator+Reducer.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Features/AppFeature/Overlay/InfoLinkSheet+Reducer.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Features/AppFeature/Overlay/SheetOverlayCoordinator+Reducer.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Features/CreatePersona/Children/Introduction/IntroductionToPersonas.swift
Show resolved
Hide resolved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1671
Description
Introduces the long awaited info button, that pops a bottom sheet with a short description of the item in question. Tapping links to other items from within the sheet replaces the text (and scrolls to the top), instead of queueing up another sheet or dismissing and showing the new one (see clip).
How to test
Screenshot
Video
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-26.at.14.17.04.mp4
Note
I also added an infolink for Behaviors (though I haven't added the string yet, in case we don't actually want this:
PR submission checklist