[ABW-3776] Unable to create new persona fix #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, but I insist we should do what I proposed on its PR: there is no point for this view to have a reducer with a Makes more sense to have it as a plain SwiftUI view that takes a closure instead. |
CyonAlexRDX
approved these changes
Sep 4, 2024
|
@CyonAlexRDX Yes, all good. We have only 10 places (for now) where we use |
|
@matiasbzurovski Agree with you. Should I do this change in this PR though? |
GhenadieVP
approved these changes
Sep 5, 2024
|
@danvleju-rdx @matiasbzurovski Let's do the improvement in a separate PR. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3776
Description
This PR fixes the issue where users could not create a new persona by explicitly declaring the
body. This was necessary due to a conflict between ourFeatureReducerprotocol and the@Reducermacro.