Fix/ABW-957 Biometrics check cancelled causes blank screen #295
Conversation
nikola-milicevic
requested review from
CyonAlexRDX,
davdroman-rdx,
GhenadieVP and
kugel3
| return .run { send in | ||
| await send(.delegate(.biometricsCheckFailed)) | ||
| } |
There was a problem hiding this comment.
| return .run { send in | |
| await send(.delegate(.biometricsCheckFailed)) | |
| } | |
| return .send(.delegate(.biometricsCheckFailed)) |
There was a problem hiding this comment.
Wholeheartedly endorse this suggested change...
There was a problem hiding this comment.
It also just became Point-Free canon yesterday https://www.pointfree.co/episodes/ep222-composable-navigation-tabs
There was a problem hiding this comment.
Unresolved for the rest of the team's visibility.
There was a problem hiding this comment.
Also heard that last night. If they are serious about it, I wonder if they couldn't provide a separate pathway for delegate actions, so we don't need to manually ignore them in the child reducer, and also don't have to go full nesting with .view...
There was a problem hiding this comment.
Well at least we have FeatureReducer now which ignores them by default. But I do agree if it becomes a widespread pattern it might be worth protocolizing it like they did with BindingAction... though seeing how involved that API ended up in practice it might just be best to keep it as-is.
…/CreationOfEntity+Reducer.swift Co-authored-by: David Roman <116723827+davdroman-rdx@users.noreply.github.com>
Description
This PR fixes the bug when user is presented blank screen after cancelling biometrics check upon account / persona creation.
In case of persona creation the flow can be dismissed, since it's modally presented, but in account creation flow the user gets stuck and the only option is to force quit the app.
Slack thread: https://rdxworks.slack.com/archives/C03QFAWBRNX/p1676379721309619