Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ABW-957 Biometrics check cancelled causes blank screen #295

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Fix/ABW-957 Biometrics check cancelled causes blank screen #295

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d22294f
Go back to step 0
nikola-milicevic Feb 14, 2023
3eba697
Update Sources/Features/CreateEntityFeature/Children/CreationOfEntity…
nikola-milicevic Feb 14, 2023
a1a08dd
Rename to createEntityFailed
nikola-milicevic Feb 14, 2023
658e451
Fix tests
nikola-milicevic Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/Features/CreateEntityFeature/Children/CreationOfEntity/CreationOfEntity+Action.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,6 @@ extension CreationOfEntity.Action {
extension CreationOfEntity.Action {
public enum DelegateAction: Sendable, Equatable {
case createdEntity(Entity)
case biometricsCheckFailed
}
}
7 changes: 4 additions & 3 deletions ...ces/Features/CreateEntityFeature/Children/CreationOfEntity/CreationOfEntity+Reducer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,10 @@ public struct CreationOfEntity<Entity: EntityProtocol>: Sendable, ReducerProtoco
))))
}

case let .internal(.system(.createEntityResult(.failure(error)))):
errorQueue.schedule(error)
return .none
case .internal(.system(.createEntityResult(.failure))):
return .run { send in
await send(.delegate(.biometricsCheckFailed))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return .run { send in
await send(.delegate(.biometricsCheckFailed))
}
return .send(.delegate(.biometricsCheckFailed))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wholeheartedly endorse this suggested change...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also just became Point-Free canon yesterday https://www.pointfree.co/episodes/ep222-composable-navigation-tabs

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolved for the rest of the team's visibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also heard that last night. If they are serious about it, I wonder if they couldn't provide a separate pathway for delegate actions, so we don't need to manually ignore them in the child reducer, and also don't have to go full nesting with .view...

Copy link
Contributor

@davdroman-rdx davdroman-rdx Feb 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well at least we have FeatureReducer now which ignores them by default. But I do agree if it becomes a widespread pattern it might be worth protocolizing it like they did with BindingAction... though seeing how involved that API ended up in practice it might just be best to keep it as-is.


case let .internal(.system(.createEntityResult(.success(entity)))):
return .run { send in
Expand Down
4 changes: 4 additions & 0 deletions Sources/Features/CreateEntityFeature/Coordinator/CreateEntityCoordinator+Reducer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ public struct CreateEntityCoordinator<
state: &state
)

case .child(.step2_creationOfEntity(.delegate(.biometricsCheckFailed))):
state.step = .step0_nameNewEntity(.init(config: state.config))
return .none

case .child(.step3_completion(.delegate(.completed))):
return .run { send in
await send(.delegate(.completed))
Expand Down