Disable navigation to empty screens #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
reviewed
Jun 7, 2023
Sources/Features/AccountListFeature/Coordinator/AccountList+Reducer.swift
Show resolved
Hide resolved
CyonAlexRDX
requested changes
Jun 7, 2023
kugel3
reviewed
Jun 7, 2023
Comment on lines
-65
to
+66
| state.destination = .messageMode(.init()) | ||
| // FIXME: Enable once the `messageMode` is implemented | ||
| // state.destination = .messageMode(.init()) |
There was a problem hiding this comment.
I already fixed this in my PR, but at the button, which is enough.
There was a problem hiding this comment.
Didn't see this ticket, so I included it in mine! Sorry.
kugel3
approved these changes
Jun 7, 2023
Comment on lines
-65
to
+66
| state.destination = .messageMode(.init()) | ||
| // FIXME: Enable once the `messageMode` is implemented | ||
| // state.destination = .messageMode(.init()) |
There was a problem hiding this comment.
Didn't see this ticket, so I included it in mine! Sorry.
CyonAlexRDX
approved these changes
Jun 7, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://radixdlt.atlassian.net/browse/ABW-1703, https://radixdlt.atlassian.net/browse/ABW-1712
Disable navigation to empty screens.