Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABW-1718 Hide Info Buttons #559

Merged
merged 2 commits into from
Jun 7, 2023
Merged

ABW-1718 Hide Info Buttons #559

merged 2 commits into from
Jun 7, 2023

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Jun 7, 2023 •
edited
Loading

Jira ticket: ABW-1718

Description

Hide the info buttons, until they are implemented. Also disabling the Message mode modal in Asset Transfer.

image

Screenshot

image image

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@CyonAlexRDX
Copy link
Contributor

LGTM! Perhaps some screenshots in Pr would be nice

@kugel3
Copy link
Contributor Author

kugel3 commented Jun 7, 2023 •
edited
Loading

There you go image

@kugel3 kugel3 force-pushed the ABW-1718_Hide-info-buttons branch from 148b8cd to b40be73 Compare June 7, 2023 11:12
@CyonAlexRDX
Copy link
Contributor

Most helpful, thank you! :D

GhenadieVP
GhenadieVP reviewed Jun 7, 2023
View reviewed changes
...eatures/AssetTransferFeature/Components/AssetTransferMessage/AssetTransferMessage+View.swift Outdated
@@ -26,16 +26,17 @@ extension AssetTransferMessage.View {

VStack(alignment: .leading, spacing: 0) {
HStack {
Button {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done here -> #554

@kugel3 kugel3 force-pushed the ABW-1718_Hide-info-buttons branch from b40be73 to 2bf007d Compare June 7, 2023 13:14
@kugel3 kugel3 merged commit 67f49ec into main Jun 7, 2023
@kugel3 kugel3 deleted the ABW-1718_Hide-info-buttons branch June 7, 2023 14:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhenadieVP GhenadieVP GhenadieVP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kugel3 @CyonAlexRDX @GhenadieVP