Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABW-1718 Hide Info Buttons #559

Merged
merged 2 commits into from
Jun 7, 2023
Merged

ABW-1718 Hide Info Buttons #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a33eb16
ABW-1718 Hide Info Buttons
kugel3 Jun 7, 2023
2bf007d
Disable Message mode button
kugel3 Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...s/AssetTransferFeature/Components/AssetTransferMessage/AssetTransferMessage+Reducer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ public struct AssetTransferMessage: Sendable, FeatureReducer {
public func reduce(into state: inout State, viewAction: ViewAction) -> EffectTask<Action> {
switch viewAction {
case .messageKindTapped:
// FIXME: Enable once the `messageMode` is implemented
// state.destination = .messageMode(.init())
state.destination = .messageMode(.init())
return .none

case .removeMessageTapped:
Expand Down
22 changes: 11 additions & 11 deletions ...ures/AssetTransferFeature/Components/AssetTransferMessage/AssetTransferMessage+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,18 @@ extension AssetTransferMessage.View {

VStack(alignment: .leading, spacing: 0) {
HStack {
// FIXME: Uncomment and implement once messageKind is implemented
// Button {
// viewStore.send(.messageKindTapped)
// } label: {
// HStack {
// Text(L10n.Common.public)
// Image(asset: AssetResource.chevronDown)
// }
// }
Text(L10n.Common.public)
// FIXME: Enable once messageKind is implemented
// Button {
// viewStore.send(.messageKindTapped)
// } label: {
// HStack {
// Text(L10n.Common.public)
// Image(asset: AssetResource.chevronDown)
// }
// }
// .textStyle(.body1HighImportance)
// .foregroundColor(.app.gray1)
.textStyle(.body1HighImportance)
.foregroundColor(.app.gray1)

Spacer()

Expand Down
9 changes: 5 additions & 4 deletions Sources/Features/CreatePersona/Children/Introduction/IntroductionToPersonas+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ extension IntroductionToPersonas {
.foregroundColor(.app.gray1)
.textStyle(.sheetTitle)

Button(L10n.CreatePersona.Introduction.learnAboutPersonas) {
viewStore.send(.showTutorial)
}
.buttonStyle(.info)
// FIXME: Uncomment and implement
// Button(L10n.CreatePersona.Introduction.learnAboutPersonas) {
// viewStore.send(.showTutorial)
// }
// .buttonStyle(.info)

Text(L10n.CreatePersona.Introduction.subtitle1)
.font(.app.body1Regular)
Expand Down
11 changes: 6 additions & 5 deletions Sources/Features/GatewaySettingsFeature/GatewaySettings+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,12 @@ extension GatewaySettings {
VStack(alignment: .leading, spacing: .small2) {
subtitle

Button(L10n.Gateways.whatIsAGateway) {
viewStore.send(.popoverButtonTapped)
}
.buttonStyle(.info)
.padding(.vertical, .medium2)
// FIXME: Uncomment and implement
// Button(L10n.Gateways.whatIsAGateway) {
// viewStore.send(.popoverButtonTapped)
// }
// .buttonStyle(.info)
// .padding(.vertical, .medium2)

Separator()
}
Expand Down
11 changes: 6 additions & 5 deletions Sources/Features/LedgerHardwareDevices/LedgerHardwareDevices+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,12 @@ extension LedgerHardwareDevices {
.padding(.bottom, .medium1)
}

// Button(L10n.LedgerHardwareDevices.ledgerFactorSourceInfoCaption) {
// viewStore.send(.whatIsALedgerButtonTapped)
// }
// .buttonStyle(.info)
// .flushedLeft
// FIXME: Uncomment and implement
// Button(L10n.LedgerHardwareDevices.ledgerFactorSourceInfoCaption) {
// viewStore.send(.whatIsALedgerButtonTapped)
// }
// .buttonStyle(.info)
// .flushedLeft
}
}
.multilineTextAlignment(.center)
Expand Down
13 changes: 7 additions & 6 deletions ...ansactionReviewFeature/TransactionReviewGuarantees/TransactionReviewGuarantees+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,13 @@ extension TransactionReviewGuarantees {
.multilineTextAlignment(.center)
.padding(.vertical, .medium3)

Button(L10n.TransactionReview.Guarantees.howDoGuaranteesWork) {
ViewStore(store).send(.view(.infoTapped))
}
.buttonStyle(.info)
.padding(.horizontal, .large2)
.padding(.bottom, .medium1)
// FIXME: Uncomment and implement
// Button(L10n.TransactionReview.Guarantees.howDoGuaranteesWork) {
// ViewStore(store).send(.view(.infoTapped))
// }
// .buttonStyle(.info)
// .padding(.horizontal, .large2)
// .padding(.bottom, .medium1)

Text(L10n.TransactionReview.Guarantees.subtitle)
.textStyle(.body1Regular)
Expand Down
20 changes: 10 additions & 10 deletions ...ansactionReviewFeature/TransactionReviewNetworkFee/TransactionReviewNetworkFee+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ extension TransactionReviewNetworkFee {
.sectionHeading
.textCase(.uppercase)

// TODO: Enable back
// TransactionReviewInfoButton {
// viewStore.send(.infoTapped)
// }
// FIXME: Uncomment and implement
// TransactionReviewInfoButton {
// viewStore.send(.infoTapped)
// }

Spacer(minLength: 0)

Expand All @@ -37,12 +37,12 @@ extension TransactionReviewNetworkFee {
.foregroundColor(.app.alert)
}

// FIXME: mainnet
// Button(L10n.TransactionReview.NetworkFee.customizeButtonTitle) {
// viewStore.send(.customizeTapped)
// }
// .textStyle(.body1StandaloneLink)
// .foregroundColor(.app.blue2)
// FIXME: Uncomment and implement
// Button(L10n.TransactionReview.NetworkFee.customizeButtonTitle) {
// viewStore.send(.customizeTapped)
// }
// .textStyle(.body1StandaloneLink)
// .foregroundColor(.app.blue2)
}
}
.padding(.horizontal, .medium3)
Expand Down
7 changes: 4 additions & 3 deletions ...tures/TransactionReviewFeature/TransactionReviewProofs/TransactionReviewProofs+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ extension TransactionReviewProofs {
.sectionHeading
.textCase(.uppercase)

TransactionReviewInfoButton {
viewStore.send(.infoTapped)
}
// FIXME: Uncomment and implement
// TransactionReviewInfoButton {
// viewStore.send(.infoTapped)
// }

Spacer(minLength: 0)
}
Expand Down