[ABW-2271] Remove spurious portfolio reloading #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
changed the title
kugel3
force-pushed
the
ABW-NNNN_Spurious-reloading
branch
from
725512e
to
3ba7ccc
Compare
kugel3
force-pushed
the
ABW-NNNN_Spurious-reloading
branch
from
3ba7ccc
to
d8c4c37
Compare
GhenadieVP
approved these changes
Oct 9, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The wallet reloads the account portfolios too often. This PR removes most of the unnecessary reloads, and even more cases where an already fetched portfolio is recreated without fetching.
Notes
The next step is probably to move to an architecture where e.g. AccountPortfolioClient emits "events" like
portfolioChange(AccountAddress)which we subscribe to, instead of a currentValueSubject of the portfolios. This will make it possible to distinguish between the first reading of an already fetched portfolio, and subsequent updates to the data. This is important because.taskis called not just when a view is first created, but every time it comes back into view, causing us to set up subscriptions too often.How to test
Try everything related to portfolio reloading, making sure that views are automatically reloaded e.g. when
PR submission checklist