[ABW-2206] Merge AccountList into Home, clean up Export/Import mnemonic prompts and display
#878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ENTED toolbar from being shown in ImportMnemonic
…ose_focus # Conflicts: RadixWallet.xcodeproj/project.pbxproj
…_not_keepIcloud__THEN__profile_gets_removed_from_saved_headerlist
Sajjon
reviewed
Nov 7, 2023
| @@ -438,6 +439,8 @@ public struct ImportOlympiaWalletCoordinator: Sendable, FeatureReducer { | |||
| saveIntoProfile: true | |||
| )) | |||
|
|
|||
| overlayWindowClient.scheduleHUD(.seedPhraseImported) | |||
There was a problem hiding this comment.
shown when a seed phrase has successfully been saved into keychain
GhenadieVP
reviewed
Nov 8, 2023
RadixWallet/Features/AccountDetailsFeature/Coordinator/AccountDetails+View.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Features/HomeFeature/Children/AccountRow/AccountList+Row+Reducer.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Features/SettingsFeature/AccountSecurity/AccountSecurity+Reducer.swift
Outdated
Show resolved
Hide resolved
…adixdlt/babylon-wallet-ios into ABW-2206_import_mnemonic_from_settings
CyonAlexRDX
changed the title
Home, clean up Export/Import mnemonic prompts and display
…dependency-additions which has support for async stream of values
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABW-2206
Description
The intended behaviour was not to import/export mnemonics from AccountDetails, but to navigate to Seed Phrases screen in Settings.
Changes
overlayWindowClient) when we import mnemonicsAccountListfeature intoHome(calling the row reducers:Home.AccountRow)AccountDetails.StateandHome.AccountRowfor shared stated usingAccountWithInfostruct, sharing logic likeexportMnemonicNeededandimportMnemonicNeededetcchangeToMainnetIfNeededfunctionality part of import profile, which was accidentally removed in previous [ABW-2427] ProfileStore sync init #860 PRDemo
Import Mnemonic
RPReplay_Final1699370103.MP4
Export Mnemonc
RPReplay_Final1699370142.MP4
Assert we show export mnemonic when XRD ->
>0RPReplay_Final1699370194.MP4
Seed Phrases screen import works as expected
RPReplay_Final1699443241.MP4
Seed Phrases screen export works as expected
RPReplay_Final1699443352.MP4
Import mnemonic by doing Legacy wallet import
trim.978CA600-D58C-4214-81C1-1E4EC855452B.MOV
Export prompt after faucet usage on Account Details
trim.8EE6899B-2F8A-493F-A1F6-5F9DF9DF7C6D.MOV