Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the registration of the Engines' assets path in propshaft #43

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

rafaelfranca
Copy link
Member

I'm an not making the mistake to commit this without someone trying it.

@dhh or @rmacklin can you check if this works in the same way as before?

@rmacklin
Copy link
Contributor

rmacklin commented Dec 4, 2021

With the integration test from #20, this change appears to pass CI - it doesn't break in the way that 66ce0f8 broke the test suite (#41)

@brenogazzola
Copy link
Collaborator

brenogazzola commented Dec 4, 2021

I've tested it against a production app already running Propshaft and the output of rake assets:reveal is identical, so it seems its correctly picking the assets from gems.

@rafaelfranca
Copy link
Member Author

rafaelfranca commented Dec 4, 2021

Thanks! @rmacklin can you open a new PR extracting the integrations tests from #20?

@rafaelfranca rafaelfranca merged commit 2143473 into main Dec 4, 2021
@rafaelfranca rafaelfranca deleted the rm-better-engine-initializer branch December 4, 2021 20:00
@rmacklin
Copy link
Contributor

rmacklin commented Dec 4, 2021

@rafaelfranca Done: #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants