Add an integration test to exercise the gem in a real application #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used for integration testing with a real application
This was created by running ``` rails plugin new propshaft --skip-active-record --skip-active-storage --skip-action-mailer --skip-action-cable ``` and importing its generated `test/dummy` folder, and then making a couple of manual updates: - [Avoid unnecessary framework `require`s][0] - [Remove unnecessary files from test app][1] [0]: rails@5ca90e0 [1]: rails@a1280df
Without the changes from 0fd7814, the second test fails with: `ActionView::Template::Error expected but nothing was raised.` because the gem would simply generate broken tags like `<link rel="stylesheet" href="" />` and `<script src=""></script>` rather than raising an exception to loudly inform the developer that the given asset can't be resolved.
rmacklin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #20
As noted in #20 (comment), this integration test appropriately failed with the change from 66ce0f8, so it can prevent regressions like #41. (Previously, the test suite wasn't exercising that initializer in the railtie.)