Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster description on home page scales horribly #11588

Closed
richard-cox opened this issue Aug 5, 2024 · 4 comments · Fixed by #11589
Closed

Cluster description on home page scales horribly #11588

richard-cox opened this issue Aug 5, 2024 · 4 comments · Fixed by #11589
Labels
area/performance kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.10.0

Comments

@richard-cox
Copy link
Member

Setup

  • Rancher version: 2.9.0

Describe the bug

  • home page shows a list of clusters and the description underneath the name
  • to get the description it was iterating over all prov clusters and then again over all mgmt clusters then overwriting the prov clusters description field

To Reproduce

  • Performance: Load many clusters that churn, see churn in function
  • Mutation: Create an EKS cluster in the old UI (with description). In new UI go to home page then edit the EKS cluster in the new UI (on edit page you'll see the description)
  • Missing Description: Create an EKS cluster in the old UI (with description). In the new UI go to the home page then the detail page for the EKS cluster and the description will show. Refresh and it won't

Expected Result

  • Performance: Should not degrade
  • Mutations should not happen

Additional context
@richard-cox richard-cox added this to the v2.10.0 milestone Aug 5, 2024
richard-cox added a commit to richard-cox/dashboard that referenced this issue Aug 5, 2024
@richard-cox
Fix prv/mgmt cluster description issues
ec3700b 
See rancher#11588 for details

- mgmt cluster is a steve resource, so can inherit the steve model
  - this resolve the issue of mgmt cluster not having a description
- prv cluster uses it's own description, falls back on mgmt description
  - custom stuff on home screen not needed
  - fixes description on detail page of legacy clusters
- remove description from hybrid model
  - this contains steve references and isn't needed
@richard-cox richard-cox mentioned this issue Aug 5, 2024
Merged
7 tasks
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 5, 2024
@richard-cox
Copy link
Member Author

/backport v2.9.next1

@github-actions github-actions bot mentioned this issue Aug 6, 2024
Closed
richard-cox added a commit to richard-cox/dashboard that referenced this issue Aug 6, 2024
@richard-cox
Fix prv/mgmt cluster description issues
0ab0f86 
See rancher#11588 for details

- mgmt cluster is a steve resource, so can inherit the steve model
  - this resolve the issue of mgmt cluster not having a description
- prv cluster uses it's own description, falls back on mgmt description
  - custom stuff on home screen not needed
  - fixes description on detail page of legacy clusters
- remove description from hybrid model
  - this contains steve references and isn't needed
richard-cox added a commit to richard-cox/dashboard that referenced this issue Aug 6, 2024
@richard-cox
Fix prv/mgmt cluster description issues
cef4876 
See rancher#11588 for details

- mgmt cluster is a steve resource, so can inherit the steve model
  - this resolve the issue of mgmt cluster not having a description
- prv cluster uses it's own description, falls back on mgmt description
  - custom stuff on home screen not needed
  - fixes description on detail page of legacy clusters
- remove description from hybrid model
  - this contains steve references and isn't needed
@izaac
Copy link
Contributor

izaac commented Aug 7, 2024

There isn't support in the E2E tests for hosted providers or the Old UI.

Is it possible to add a unit test for this?

@richard-cox
Copy link
Member Author

@izaac the home page clusters work with an agnostic cluster resource type of provisioning cluster. RKE2 and hosted providers are created in the new ui via that prov cluster type. The old ui (ember / rke1) create clusters a different way but end up as prov clusters in the home page, that angle is covered by the second referenced PR.

@izaac
Copy link
Contributor

izaac commented Aug 9, 2024

Moving to done. Thanks for clarifying @richard-cox

@izaac izaac closed this as completed Aug 9, 2024
nwmac pushed a commit to nwmac/dashboard that referenced this issue Aug 13, 2024
@richard-cox @nwmac
Fix prv/mgmt cluster description issues
25650a2 
See rancher#11588 for details

- mgmt cluster is a steve resource, so can inherit the steve model
  - this resolve the issue of mgmt cluster not having a description
- prv cluster uses it's own description, falls back on mgmt description
  - custom stuff on home screen not needed
  - fixes description on detail page of legacy clusters
- remove description from hybrid model
  - this contains steve references and isn't needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging a pull request may close this issue.

Fix home page cluster description scaling issue richard-cox/dashboard
2 participants
@izaac @richard-cox