Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home page cluster description scaling issue #11589

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Aug 5, 2024

Summary

Fixes #11588

Occurred changes and/or fixed issues

  • mgmt cluster is a steve resource, so can inherit the steve model
    • this resolve the issue of mgmt cluster not having a description
  • prv cluster uses it's own description, falls back on mgmt description
    • custom stuff on home screen not needed
    • fixes description on detail page of legacy clusters
  • remove description from hybrid model
    • this contains steve references and isn't needed

Technical notes summary

home page prov.description --> prov's description from extended steve model || mgmt's description from extended steve model

Areas or cases that should be tested

  • One of EKS/AKS/GKE cluster created in old ui AND RKE2 cluster description should display on
    • home page cluster list
    • side nav
    • cluster's detail page

Screenshot/Video

image

image

image

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.10.0 milestone Aug 5, 2024
@richard-cox richard-cox self-assigned this Aug 5, 2024
@richard-cox richard-cox changed the title Fix prv/mgmt cluster description issues Fix home page scaling issue Aug 5, 2024
@richard-cox richard-cox changed the title Fix home page scaling issue Fix home page cluster description scaling issue Aug 5, 2024
@richard-cox richard-cox marked this pull request as ready for review August 5, 2024 16:43
See rancher#11588 for details

- mgmt cluster is a steve resource, so can inherit the steve model
  - this resolve the issue of mgmt cluster not having a description
- prv cluster uses it's own description, falls back on mgmt description
  - custom stuff on home screen not needed
  - fixes description on detail page of legacy clusters
- remove description from hybrid model
  - this contains steve references and isn't needed
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richard-cox , I've created a RKE1 GKE cluster using the old UI and RKE2 Digital Ocean Cluster and I can see the descriptions in the key areas, so I would say LGTM!
Screenshot 2024-08-06 at 16 38 23
Screenshot 2024-08-06 at 16 38 27
Screenshot 2024-08-06 at 16 38 31
Screenshot 2024-08-06 at 16 38 39
Screenshot 2024-08-06 at 16 38 44

@richard-cox richard-cox merged commit 4fe4aa1 into rancher:master Aug 7, 2024
28 checks passed
@richard-cox richard-cox deleted the fix-home-scaling-issue branch August 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster description on home page scales horribly
2 participants