Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home page cluster description scaling issue #11595

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Fix home page cluster description scaling issue #11595

merged 2 commits into from
Aug 8, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Aug 6, 2024 •
edited
Loading

Summary

Fixes #11593

Occurred changes and/or fixed issues

backport of #11589

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox
Fix prv/mgmt cluster description issues
0ab0f86 
See rancher#11588 for details

- mgmt cluster is a steve resource, so can inherit the steve model
  - this resolve the issue of mgmt cluster not having a description
- prv cluster uses it's own description, falls back on mgmt description
  - custom stuff on home screen not needed
  - fixes description on detail page of legacy clusters
- remove description from hybrid model
  - this contains steve references and isn't needed
@richard-cox
Fix lint
035fc68
@richard-cox richard-cox added this to the v2.9.next1 milestone Aug 6, 2024
@richard-cox richard-cox self-assigned this Aug 6, 2024
@richard-cox richard-cox linked an issue Aug 6, 2024 that may be closed by this pull request
[backport v2.9.next1] Cluster description on home page scales horribly #11593
Closed
@richard-cox richard-cox marked this pull request as ready for review August 6, 2024 13:12
@richard-cox
Copy link
Member Author

@aalves08 can you take a look?

aalves08
aalves08 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mate! all descriptions seem to be displayed just fine 🙏
Screenshot 2024-08-08 at 10 40 47
Screenshot 2024-08-08 at 10 40 48
Screenshot 2024-08-08 at 10 40 56
Screenshot 2024-08-08 at 10 41 01

@richard-cox richard-cox merged commit 4a8cb96 into rancher:release-2.9 Aug 8, 2024
27 checks passed
@richard-cox richard-cox deleted the 2.9-fix-home-scaling-issue branch August 8, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalves08 aalves08 aalves08 approved these changes

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v2.9.1
Development

Successfully merging this pull request may close these issues.

[backport v2.9.next1] Cluster description on home page scales horribly
2 participants
@richard-cox @aalves08