Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure loading indicator doesn't show outside it's context #11846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Sep 6, 2024

Summary

Fixes #5245

Occurred changes and/or fixed issues

  • Windows Manager sits below side nav and main screen content
    • shell, log streaming
  • The relative and content loading indicator covers a specific area or the main screen content
  • Bug - relative and content loading indicator appears over windows manager
  • Fix
    • apply different z-index to main and other modes of loading indicator
    • assign a higher z-index to windows manager (higher than main screen content)

Technical notes summary

Tested

  • mode - relative
    • shell/chart/monitoring/index.vue
    • shell/components/Wizard.vue
    • shell/components/nav/GlobalLoading.vue
    • shell/pages/auth/login.vue
  • mode - content
    • shell/pages/c/_cluster/monitoring/index.vue
    • shell/edit/namespace.vue - shell/pages/c/_cluster/settings/banners.vue
  • mode - main
    • not actually used... and currently broken (new burger menu is under it)
  • outside content (such as burger menu, namespace filter, user avatar, etc) correctly shows above relative and content loading indicator
  • wm drag and drop (working in vue3!)

Areas or cases that should be tested

This impacts places where we show the Loading... text in the centre of a opaque area. I've tested a lot above but via tweaking code. It would sense to maybe click around playing with the network tool throttling controls

Areas which could experience regressions

Loading indicator, window manager (kube shell, container shell, container logs, helm chart logs)

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

- Windows Manager sits below side nav and main screen content
  - shell, log streaming
- The relative and content loading indicator covers a specific area or the main screen content
- Bug - relative and content loading indicator appears over windows manager
- Fix
  - apply different z-index to main and other modes of loading indicator
  - assign a higher z-index to windows manager (higher than main screen content)
- Tested
  - mode - relative
    - shell/chart/monitoring/index.vue
    - shell/components/Wizard.vue
    - shell/components/nav/GlobalLoading.vue
    - shell/pages/auth/login.vue
  - mode - content
    - shell/pages/c/_cluster/monitoring/index.vue
    - shell/edit/namespace.vue
    - shell/pages/c/_cluster/settings/banners.vue
  - mode - main
   - not actually used... and currently broken (new burger menu is under it)
  - outside correctly shows above relative and content
     - burger menu, namespace filter, user avatar
  - wm drag and drop (working in vue3!)
@richard-cox richard-cox added this to the v2.10.0 milestone Sep 6, 2024
@richard-cox richard-cox self-assigned this Sep 6, 2024
@richard-cox richard-cox marked this pull request as ready for review September 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page loading indicator covers the window manager
1 participant