Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure loading indicator doesn't show outside it's context #11846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 6, 2024

  1. Ensure loading indicator doesn't show outside it's context

    - Windows Manager sits below side nav and main screen content
      - shell, log streaming
    - The relative and content loading indicator covers a specific area or the main screen content
    - Bug - relative and content loading indicator appears over windows manager
    - Fix
      - apply different z-index to main and other modes of loading indicator
      - assign a higher z-index to windows manager (higher than main screen content)
    - Tested
      - mode - relative
        - shell/chart/monitoring/index.vue
        - shell/components/Wizard.vue
        - shell/components/nav/GlobalLoading.vue
        - shell/pages/auth/login.vue
      - mode - content
        - shell/pages/c/_cluster/monitoring/index.vue
        - shell/edit/namespace.vue
        - shell/pages/c/_cluster/settings/banners.vue
      - mode - main
       - not actually used... and currently broken (new burger menu is under it)
      - outside correctly shows above relative and content
         - burger menu, namespace filter, user avatar
      - wm drag and drop (working in vue3!)
    richard-cox committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    62619c2 View commit details
    Browse the repository at this point in the history