iOS 5 CFI Assertion Parse Fix

[matwood]

The stream.ignore appears broken on the iOS 5 c++stdlib and moves past the end of the stream when ignoring up to the closing bracket. iss.eof() ends up set to true.

Changing it to a loop fixes the issue for iOS5 and still works correctly on iOS6. I don't usually code in c++ so if there is a more idiomatic way to fix the issue please let me know.

[bluefirepatrick]

Hi Michael,

Thank you for the information. We will take a look at that branch.

Patrick

From: Michael Atwood <notifications@github.hscsec.cnmailto:notifications@github.com>
Reply-To: readium/readium-sdk <reply@reply.github.hscsec.cnmailto:reply@reply.github.com>
Date: Thursday, September 19, 2013 1:09 PM
To: readium/readium-sdk <readium-sdk@noreply.github.hscsec.cnmailto:readium-sdk@noreply.github.com>
Subject: [readium-sdk] iOS 5 CFI Assertion Parse Fix (#19)

The stream.ignore appears broken on the iOS 5 c++stdlib and moves past the end of the stream when ignoring up to the closing bracket. iss.eof() ends up set to true.

Changing it to a loop fixes the issue for iOS5 and still works correctly on iOS6. I don't usually code in c++ so if there is a more idiomatic way to fix the issue please let me know.

---

You can merge this Pull Request by running

git pull https://github.com/bibliolabs/readium-sdk master

Or view, comment on, or merge it at:

#19

Commit Summary

• Merge pull request help me #1 from readium/master
• * The ignore function returns eof() past the delimiter on ios 5. Replaced ignore

File Changes

• M ePub3/ePub/cfi.cpphttps://github.com/iOS 5 CFI Assertion Parse Fix #19/files#diff-0 (5)

Patch Links:

• https://github.com/readium/readium-sdk/pull/19.patch
• https://github.com/readium/readium-sdk/pull/19.diff

[rkwright]

This issue is ancient and we do not support iOS5 (nor does APple, so am going to close this issue. If similar problems are encountered please open a new issue and we will investigate.