Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation Warnings with v2 and php 8.0 #637

Open
tolry opened this issue Sep 29, 2021 · 1 comment
Open

Deprecation Warnings with v2 and php 8.0 #637

tolry opened this issue Sep 29, 2021 · 1 comment
Labels
bug?

Comments

@tolry
Copy link

tolry commented Sep 29, 2021 •
edited
Loading

Describe the bug

php 8.0 deprecated libxml_disable_entity_loader since it's no longer needed with the updated libxml version used

To Reproduce

Run version 2.x with deprecation activated (e.g. error_reporting(-1);)

Expected behavior

Getting no deprecation warnings.

Your Environment

  • Which version of this library are you using? 2.12.22
  • Which version of php are you using? 8.0.11

I have a fix ready here and could submit this, if wanted.
@tolry tolry added the bug? label Sep 29, 2021
@pabloolvcastro
Copy link

pabloolvcastro commented Feb 28, 2023 •
edited
Loading

I was wondering when this would get fixed. We are currently facing some problems with classes that implement basic PHP interfaces, and the return type has changed in PHP 8. e.g. Recurly_Pager (pager.php) and the interface Iterator. We are running the library version 2.12.37.

pabloolvcastro pushed a commit to pabloolvcastro/recurly-client-php that referenced this issue Mar 2, 2023
Refactor project for compatibility with PHP 8+
1088dc4 
The changes promoted by this commint mantain compatibility with previous versions as well. A mix of valid return types with the annotation ReturnTypeWillChange was used to guarantee compatibility e.g mixed new type

Ref
recurly#637
pabloolvcastro pushed a commit to pabloolvcastro/recurly-client-php that referenced this issue Mar 2, 2023
Refactor project for compatibility with PHP 8+
83429ff 
The changes promoted by this commit maintain compatibility with previous versions as well. A mix of valid return types with the annotation ReturnTypeWillChange was used to guarantee compatibility, e.g. mixed new type.

Ref
recurly#637
pabloolvcastro pushed a commit to pabloolvcastro/recurly-client-php that referenced this issue Mar 2, 2023
Includes PHP 8+ compatibility check composer script.
2c76458 
This is an optional commit. It provides tools to help with compatibility checks for PHP 8+.

Ref recurly#637
@pabloolvcastro pabloolvcastro mentioned this issue Mar 2, 2023
Closed
pabloolvcastro pushed a commit to pabloolvcastro/recurly-client-php that referenced this issue Jul 4, 2023
@pabloolvcastro
Refactor project for compatibility with PHP 8+
18f85ff 
The changes promoted by this commit maintain compatibility with previous versions as well. A mix of valid return types with the annotation ReturnTypeWillChange was used to guarantee compatibility, e.g. mixed new type.

Ref
recurly#637
pabloolvcastro pushed a commit to pabloolvcastro/recurly-client-php that referenced this issue Jul 4, 2023
@pabloolvcastro
Includes PHP 8+ compatibility check composer script.
c3ebef3 
This is an optional commit. It provides tools to help with compatibility checks for PHP 8+.

Ref recurly#637
pabloolvcastro pushed a commit to pabloolvcastro/recurly-client-php that referenced this issue Nov 1, 2023
@pabloolvcastro
Refactor project for compatibility with PHP 8+
44ebec6 
The changes promoted by this commit maintain compatibility with previous versions as well. A mix of valid return types with the annotation ReturnTypeWillChange was used to guarantee compatibility, e.g. mixed new type.

Ref
recurly#637
pabloolvcastro pushed a commit to pabloolvcastro/recurly-client-php that referenced this issue Nov 1, 2023
@pabloolvcastro
Includes PHP 8+ compatibility check composer script.
8774be9 
This is an optional commit. It provides tools to help with compatibility checks for PHP 8+.

Ref recurly#637
pabloolvcastro pushed a commit to pabloolvcastro/recurly-client-php that referenced this issue May 7, 2024
@pabloolvcastro
Refactor project for compatibility with PHP 8+
f5eae0a 
The changes promoted by this commit maintain compatibility with previous versions as well. A mix of valid return types with the annotation ReturnTypeWillChange was used to guarantee compatibility, e.g. mixed new type.

Ref
recurly#637
pabloolvcastro pushed a commit to pabloolvcastro/recurly-client-php that referenced this issue May 7, 2024
@pabloolvcastro
Includes PHP 8+ compatibility check composer script.
922287f 
This is an optional commit. It provides tools to help with compatibility checks for PHP 8+.

Ref recurly#637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tolry @pabloolvcastro