V2 refactor compatibility php 8 plus #749
Closed
+89
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvemado
approved these changes
Mar 2, 2023
jenopaolo
approved these changes
Mar 2, 2023
iwishiwala
approved these changes
Mar 2, 2023
joneiros
approved these changes
Mar 2, 2023
srth12
approved these changes
Mar 3, 2023
pabloolvcastro
force-pushed
the
v2-refactor-compatibility-php-8-plus
branch
from
2c76458
to
c3ebef3
Compare
pabloolvcastro
force-pushed
the
v2-refactor-compatibility-php-8-plus
branch
from
c3ebef3
to
8774be9
Compare
added 2 commits
May 7, 2024 13:49
The changes promoted by this commit maintain compatibility with previous versions as well. A mix of valid return types with the annotation ReturnTypeWillChange was used to guarantee compatibility, e.g. mixed new type. Ref recurly#637
This is an optional commit. It provides tools to help with compatibility checks for PHP 8+. Ref recurly#637
pabloolvcastro
force-pushed
the
v2-refactor-compatibility-php-8-plus
branch
from
8774be9
to
922287f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Reviewers,
Please review this PR regarding PHP 8+ compatibility. And could you merge it if you feel it meets expectations?
Goal
Fix errors and warnings caused by upgrading the runtime PHP version to 8+, keeping compatibility with <=7.4 versions and not changing business logic. You will find the error log file that contains the error I was facing that triggered the making of this PR.
All changes were made based on compatibility check results provided by the tool in the commit 2c76458 (this commit is entirely optional and can be removed from the branch if required). Compatibility check results are attached to this PR (you will notice that I left some compatibility check items as they go beyond my initial intention, e.g.
PHP has reserved all method names with a double underscore prefix for future use).This change keeps code compatibility with PHP's previous versions and will work with <= 7.4. The whole test suite was run using PHP 7.4 and PHP 8.1. Test suit execution results can be found attached to this PR.
There are no logic changes in this PR apart from
lib/recurly/coupon.phpline 125lib/recurly/client.phpline 139Supporting files
Fix created for
https://github.com/proposify
Ref
#637