tests: improve CloudRetentionTest #10327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was omitting the actual exception.
Avoid emitting WARN log during shutdown.
This test was: - Checking for retention enforcement in a way that overlapped with ongoing uploads, so had unpredictable runtime. - Checking total object size rather than logical partition size, so its stability was influenced by extra objects like indices. Fixes redpanda-data#10282
|
Test failure is: |
VladLazar
approved these changes
Apr 26, 2023
| @@ -1806,7 +1806,7 @@ ss::future<> ntp_archiver::housekeeping() { | |||
| co_await garbage_collect(); | |||
| } | |||
| } catch (std::exception& e) { | |||
| vlog(_rtclog.warn, "Error occured during housekeeping", e.what()); | |||
| vlog(_rtclog.warn, "Error occurred during housekeeping: {}", e.what()); | |||
There was a problem hiding this comment.
We should really write a clang-tidy check for this ...
There was a problem hiding this comment.
did someone say clang-tidy check?
There was a problem hiding this comment.
Yeah. It would be great if we had a check that parsed vlog and format invocations and ensured the number of placeholders ({}) matches the number of args provided.
There was a problem hiding this comment.
yeh that would be cool. IIUC this has been asked for from libfmt but apparently it isn't possible. clang-tidy does seem like a reasonable solution
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on this, I also noticed some logging issues with the archival housekeeping that I've fixed opportunistically.
Fixes #10282
Backports Required
Release Notes