Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: improve CloudRetentionTest #10327

Merged
merged 3 commits into from
Apr 26, 2023
Merged

tests: improve CloudRetentionTest #10327

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee2c2b7
archival: fix error message in housekeeping
jcsp Apr 25, 2023
95b1292
archival: refine housekeeping logging
jcsp Apr 25, 2023
d3fa44e
tests: improve CloudRetentionTest
jcsp Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v/archival/ntp_archiver_service.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,7 +1806,7 @@ ss::future<> ntp_archiver::housekeeping() {
co_await garbage_collect();
}
} catch (std::exception& e) {
vlog(_rtclog.warn, "Error occured during housekeeping", e.what());
vlog(_rtclog.warn, "Error occurred during housekeeping: {}", e.what());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really write a clang-tidy check for this ...

Copy link
Member

@dotnwat dotnwat May 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did someone say clang-tidy check?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. It would be great if we had a check that parsed vlog and format invocations and ensured the number of placeholders ({}) matches the number of args provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh that would be cool. IIUC this has been asked for from libfmt but apparently it isn't possible. clang-tidy does seem like a reasonable solution

}
}

Expand Down