[v22.3.x] Soft assert on different sizes of shard_fetch collections
#10701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `shard_fetch` collections (results, responses, and metrics) get to `fill_fetch_responses`, soft assert the invariant that they have to be the same size. If they are not, only process the common subset of those. That may result in empty fetch responses, which is bad, but probably better than segfaulting. (cherry picked from commit e51f674)
Soft assert the invariant the `shard_fetch` collections (requests, responses, and metrics) have to be the same size. Hard assert in `empty()` is converted into a soft assert, and the function is actually used in `handle_shard_fetch()` (it was unused before that). (cherry picked from commit ab4f049)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #10677