Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.3.x] Soft assert on different sizes of shard_fetch collections #10701

Merged
merged 2 commits into from
May 12, 2023
Merged

[v22.3.x] Soft assert on different sizes of shard_fetch collections #10701

merged 2 commits into from
May 12, 2023

Commits on May 11, 2023

  1. k/fetch: soft assert on diff sizes of shard_fetch collections 

    When the `shard_fetch` collections (results, responses, and metrics)
get to `fill_fetch_responses`, soft assert the invariant that
they have to be the same size. If they are not, only process
the common subset of those. That may result in empty fetch responses,
which is bad, but probably better than segfaulting.

(cherry picked from commit e51f674)
    @dlex @vbotbuildovich
    dlex authored and vbotbuildovich committed May 11, 2023
    Configuration menu
    Copy the full SHA
    babeaa0 View commit details
    Browse the repository at this point in the history

  2. k/fetch: soft assert on diff collection sizes in shard_fetch::empty() 

    Soft assert the invariant the `shard_fetch` collections
(requests, responses, and metrics) have to be the same size.

Hard assert in `empty()` is converted into a soft assert, and
the function is actually used in `handle_shard_fetch()`
(it was unused before that).

(cherry picked from commit ab4f049)
    @dlex @vbotbuildovich
    dlex authored and vbotbuildovich committed May 11, 2023
    Configuration menu
    Copy the full SHA
    a659c49 View commit details
    Browse the repository at this point in the history