rpk: patch group seek #4594
Merged
rpk: patch group seek #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajfabbri
previously approved these changes
May 6, 2022
|
This broke some tests, but I'm guessing those tests were coded to incorrect behavior -- will take a look. |
We add our own.
For rpk group seek, if we seeked in a group that had no topics, we would list *all* topics (as is the api for list) and then commit a group to the beginning of *all* topics. We now only seek if there are topics to seek, otherwise we print the standard output that no offset was changed. We also fix this potential seek problem in rpk group describe, but realistically all groups have topics assigned.
|
And again #4772 |
r-vasquez
approved these changes
Jul 21, 2022
|
Milestone set to v22.1.x-next but never made it to v22.1.x |
|
@twmb did you intend to get this into v22.1.x? |
|
It's not critically important to backport, I'd avoid it personally -- it made it into 22.2, and this is only really important to fix something for an end-user error anyway. |
joejulian
pushed a commit
to joejulian/redpanda
that referenced
this pull request
Mar 10, 2023
rpk: patch group seek
joejulian
pushed a commit
to joejulian/redpanda
that referenced
this pull request
Mar 24, 2023
…fsets rpk: patch group seek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
rpk group seekhad a bug that would seek to the start of all topics for a non-existent group. This patches that.Release notes
rpk group seekwould seek to the start of all topics if seeking a non-existent group