Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: patch group seek #4594

Merged
merged 4 commits into from
Jul 21, 2022
Merged

rpk: patch group seek #4594

merged 4 commits into from
Jul 21, 2022

Commits on Jul 19, 2022

  1. rpk,k8s: go mod tidy

    @twmb
    twmb committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    12db639 View commit details
    Browse the repository at this point in the history

  2. rpk: disable default autocompletion command 

    We add our own.
    @twmb
    twmb committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    0c4abab View commit details
    Browse the repository at this point in the history

  3. rpk dbus: switch away from deprecated APIs

    @twmb
    twmb committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    9152203 View commit details
    Browse the repository at this point in the history

  4. rpk: avoid listing offsets for no topics, fix group seek 

    For rpk group seek, if we seeked in a group that had no topics, we would
list *all* topics (as is the api for list) and then commit a group to
the beginning of *all* topics.

We now only seek if there are topics to seek, otherwise we print the
standard output that no offset was changed.

We also fix this potential seek problem in rpk group describe, but
realistically all groups have topics assigned.
    @twmb
    twmb committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    15df1b3 View commit details
    Browse the repository at this point in the history