-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v21.11.x] redpanda: shutdown quota manager after kafka server is stopped #4673
Conversation
Quota manager refrence is a part of request context. We need to make sure that quota manager is available as long as the kafka server is running. Moved quota manager initialization before waiting for Kafka server shutdown to make sure that its reference is available for all requests that are being processed. (cherry picked from commit 3253995)
which milestone should this PR belong to? |
adding to the v21.11.17 milestone so we don't lose track of this for future release |
Just curious why we want to place this cherry-picked commit into a point release. Is it intended to fix something? I remember also observing a problem that necessitated this fix and coming to the realization that its only an issue if the portion of work that is done by Also a |
This fixes shutdown sequence, it may lead to segmentation fault during redpanda shutdown. |
Ok, how though? I see that background work is protected by the connections gate as well |
Before this patch |
Needs CI failure linked to issue. |
I am not sure if that was a CI failure we spotted that in one of the consumer clusters. It was related with the fix for #4051 |
@graphcareful what's left for approval on this PR? |
All good , LGTM |
@graphcareful can you click Approve button |
Quota manager refrence is a part of request context. We need to make
sure that quota manager is available as long as the kafka server is
running. Moved quota manager initialization before waiting for Kafka
server shutdown to make sure that its reference is available for all
requests that are being processed.
(cherry picked from commit 3253995)