Two phase group processing follow up #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnwat @travisdowns I've applied your suggestions from post-merge review of #4579 |
Extend group lifecycle in both the first and second stage of join and sync request processing. Signed-off-by: Michal Maslanka <[email protected]>
Changed `group_initial_rebalance_delay` to 3 seconds. This is the default value set in Kafka. Signed-off-by: Michal Maslanka <[email protected]>
Signed-off-by: Michal Maslanka <[email protected]>
mmaslankaprv
force-pushed
the
two-phase-group-processing-follow-up
branch
from
5b5c5de
to
ef051a5
Compare
dotnwat
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Follow up after post merge review of #4579
Fixes #ISSUE-NUMBER, Fixes #ISSUE-NUMBER, ...
Release notes