Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.1.x] cluster: clean up config error logging #5012

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport from pull request: #4942.

There are a bunch of places we log config values on
error, which are currently safe for secrets (because
secrets are all freeform strings that cannot fail
validation), but future-proof these paths by using
format_raw to ensure that if we added validated+secret
fields in future they'd be redacted properly.

(cherry picked from commit b74e04a)
@vbotbuildovich vbotbuildovich added this to the v22.1.4 milestone Jun 2, 2022
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jun 2, 2022
@ajfabbri ajfabbri marked this pull request as ready for review June 3, 2022 18:46
@ajfabbri ajfabbri requested a review from dotnwat as a code owner June 3, 2022 18:46
@ajfabbri ajfabbri self-requested a review June 3, 2022 20:43
Copy link
Contributor

@ajfabbri ajfabbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajfabbri ajfabbri merged commit bace6ce into redpanda-data:v22.1.x Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants