cluster: clean up config error logging #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a bunch of places we log config values on error, which are currently safe for secrets (because secrets are all freeform strings that cannot fail validation), but future-proof these paths by using format_raw to ensure that if we added validated+secret fields in future they'd be redacted properly.
jcsp
requested review from
dotnwat,
mmaslankaprv,
ztlpn and
VadimPlh
as code owners
andrwng
approved these changes
May 26, 2022
| vlog( | ||
| clusterlog.trace, | ||
| "merge_apply_result: data {} {}", | ||
| fmt::ptr(&data), |
There was a problem hiding this comment.
Good call removing this. Nothing secret revealed here, but I'm not sure how useful this actually is (maybe if you're in a debugger or something).
There was a problem hiding this comment.
Yeah, this was something left behind from ancient debugging that I was cleaning up while making the pass.
dotnwat
approved these changes
May 27, 2022
|
nit: i find the name |
Yes... it's raw in that the value it takes is raw YAML rather than a validated property value, but point taken. |
|
/backport v22.1.x milestone=v22.1.4 |
|
/backport v21.11.x milestone=v21.11.17 |
|
Failed to run cherry-pick command. I executed the below command: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
There are a bunch of places we log config values on
error, which are currently safe for secrets (because
secrets are all freeform strings that cannot fail
validation), but future-proof these paths by using
format_raw to ensure that if we added validated+secret
fields in future they'd be redacted properly.
Release notes