-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v21.11.x] cluster: clean up config error logging #5014
[v21.11.x] cluster: clean up config error logging #5014
Conversation
Accidentally had |
There are a bunch of places we log config values on error, which are currently safe for secrets (because secrets are all freeform strings that cannot fail validation), but future-proof these paths by using format_raw to ensure that if we added validated+secret fields in future they'd be redacted properly. (cherry picked from commit b74e04a) Conflicts: src/v/cluster/config_manager.cc src/v/redpanda/admin_server.cc
04e61a4
to
2b70d9f
Compare
For posterity, the conflict here is that in the original PR b74e04a, one of the things we do in admin_server.cc is validate that the changes we're going to apply are valid, and we log a message in case of errors. In this case, since we're not doing that validation, seems we're in the clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Might be good to get another look from Noah if he's around since it looks like he was a reviewer of some of the config management work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok with respect to the conflicts that occurred.
my only concern would be that whatever search was performed to find the log points which needed an update for redaction purposes would need to be repeated in 21.11.x etc to take into account code churn etc...
Backport from pull request #4942.
This one required manual editing.