Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rpk topic add-partition panic #5369

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Fix rpk topic add-partition panic #5369

merged 2 commits into from
Jul 7, 2022

Conversation

r-vasquez
Copy link
Contributor

Cover letter

Fixes a bug that caused rpk topic add-partitions to panic when an unfeasible number of partitions were passed.

Fixes #5351

Release notes

  • rpk: Fix a bug that caused rpk topic add-partitions to panic when an unfeasible number of partitions were passed

@r-vasquez r-vasquez changed the title Fix add partition panic Fix rpk topic add-partition panic Jul 6, 2022
@r-vasquez r-vasquez changed the title Fix rpk topic add-partition panic Fix rpk topic add-partition panic Jul 6, 2022
@r-vasquez r-vasquez marked this pull request as ready for review July 6, 2022 23:52
@r-vasquez r-vasquez requested review from jcsp and twmb and removed request for dotnwat, twmb, 0x5d and NyaliaLui July 6, 2022 23:52
twmb
twmb approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@twmb twmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, ty.

@twmb twmb merged commit 61b6520 into redpanda-data:dev Jul 7, 2022
@mmedenjak mmedenjak added the kind/bug Something isn't working label Jul 7, 2022
@r-vasquez r-vasquez deleted the fix-add-partition-panic branch July 12, 2022 22:13
@r-vasquez r-vasquez mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@jcsp jcsp Awaiting requested review from jcsp

Assignees
No one assigned
Labels
area/rpk kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpk: segfault on errors in topic add-partitions
3 participants
@r-vasquez @twmb @mmedenjak