-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v22.1.x] rpk topic error remap #5639
[v22.1.x] rpk topic error remap #5639
Conversation
Note: re-run CI once #5634 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing import, which was brought in here: bac883a
[ERROR:2022-07-26 13:25:46,790]: Failed to import rptest.tests.rpk_topic_test, which may indicate a broken test that cannot be loaded: NameError: name 'parametrize' is not defined
Update: Cherry picked bac883a |
nit: It should probably have come first. I don't want to hold up the build, though. |
Failures seem to be because this is not backported: #4953 |
At this point, I feel like we should just backport the Go code and drop the Python. The Go code is minimal, but this is starting to involve more and more unrelated commits. |
Backport is happening: #5659 |
e71b263
to
9280054
Compare
I cancelled the build - I'll rebuild when #5659 is merged. |
@r-vasquez sorry, you now have a conflict, but #5659 is merged, so hopefully the build will succeed. I think you can drop bac883a, since the equivalent is merged. |
9280054
to
ac8bb7c
Compare
Update: Rebased and dropped bac883a |
Fixes #5619
Backport of multiple commits.
Cherry-picked:
rpk topic add-partition
panic #5369)rpk topic add-partition
panic #5369)