Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.1.x] rpk topic error remap #5639

Merged
merged 5 commits into from
Jul 26, 2022

Conversation

@r-vasquez r-vasquez requested a review from BenPope July 26, 2022 01:06
@r-vasquez r-vasquez changed the title V22.1.x rpk topic err remap [v22.1.x] rpk topic error remap Jul 26, 2022
@r-vasquez
Copy link
Contributor Author

Note: re-run CI once #5634 is merged.

@mmedenjak mmedenjak added kind/bug Something isn't working kind/backport PRs targeting a stable branch community and removed community labels Jul 26, 2022
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing import, which was brought in here: bac883a

[ERROR:2022-07-26 13:25:46,790]: Failed to import rptest.tests.rpk_topic_test, which may indicate a broken test that cannot be loaded: NameError: name 'parametrize' is not defined

@r-vasquez
Copy link
Contributor Author

Update:

Cherry picked bac883a

@BenPope BenPope added this to the v22.1.6 milestone Jul 26, 2022
@BenPope
Copy link
Member

BenPope commented Jul 26, 2022

Update:

Cherry picked bac883a

nit: It should probably have come first. I don't want to hold up the build, though.

@BenPope
Copy link
Member

BenPope commented Jul 26, 2022

Failures seem to be because this is not backported: #4953

@twmb
Copy link
Contributor

twmb commented Jul 26, 2022

At this point, I feel like we should just backport the Go code and drop the Python. The Go code is minimal, but this is starting to involve more and more unrelated commits.

@BenPope
Copy link
Member

BenPope commented Jul 26, 2022

At this point, I feel like we should just backport the Go code and drop the Python. The Go code is minimal, but this is starting to involve more and more unrelated commits.

Backport is happening: #5659

@r-vasquez r-vasquez force-pushed the v22.1.x-rpk-topic-err-remap branch from e71b263 to 9280054 Compare July 26, 2022 18:05
@r-vasquez
Copy link
Contributor Author

r-vasquez commented Jul 26, 2022

Update:

Re-ordered the commit history:

@BenPope
Copy link
Member

BenPope commented Jul 26, 2022

I cancelled the build - I'll rebuild when #5659 is merged.

@BenPope
Copy link
Member

BenPope commented Jul 26, 2022

@r-vasquez sorry, you now have a conflict, but #5659 is merged, so hopefully the build will succeed. I think you can drop bac883a, since the equivalent is merged.

@r-vasquez r-vasquez force-pushed the v22.1.x-rpk-topic-err-remap branch from 9280054 to ac8bb7c Compare July 26, 2022 19:44
@r-vasquez
Copy link
Contributor Author

Update:

Rebased and dropped bac883a

@BenPope BenPope dismissed their stale review July 26, 2022 19:46

Changes have been made

@BenPope BenPope added the ci-repeat-5 repeat tests 5x concurrently to check for flakey tests; self-cancelling label Jul 26, 2022
@BenPope BenPope merged commit ce21d57 into redpanda-data:v22.1.x Jul 26, 2022
@r-vasquez r-vasquez deleted the v22.1.x-rpk-topic-err-remap branch July 29, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk ci-repeat-5 repeat tests 5x concurrently to check for flakey tests; self-cancelling kind/backport PRs targeting a stable branch kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants