Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.1.x] rpk: improve wording in topic create: replication factor must be odd #5621

Closed
wants to merge 1 commit into from
Closed

[v22.1.x] rpk: improve wording in topic create: replication factor must be odd #5621

wants to merge 1 commit into from

Conversation

r-vasquez
Copy link
Contributor

(cherry picked from commit 2eeed76)

Backport #4786
Fixes #5619

@r-vasquez r-vasquez mentioned this pull request Jul 25, 2022
Open
@BenPope
Copy link
Member

BenPope commented Jul 25, 2022

I'll rerun this after #5631 has been fixed.

BenPope
BenPope requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

git cherry-pick -x e26c0b42327b3c5bc4d6838b94d176bbdf5a4fb0

As the first commit

@BenPope BenPope self-requested a review July 25, 2022 23:06
@r-vasquez r-vasquez closed this Jul 26, 2022
@r-vasquez
Copy link
Contributor Author

Backported all the required commits in: #5639

@r-vasquez r-vasquez deleted the v22.1.x-odd-replica-factor-text branch July 26, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@0x5d 0x5d Awaiting requested review from 0x5d 0x5d is a code owner

@LenaAn LenaAn Awaiting requested review from LenaAn

@BenPope BenPope Awaiting requested review from BenPope

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-vasquez @BenPope @twmb