[v22.1.x] kafka: validate user provided create_topic configuration literals
#5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 26, 2022 17:46
Some of the topic creation configurations take string literals as values. Prior to this patch creating a topic with an unexpected string literal value failed without returning any error message due to an unhandled exception thrown in the parsing of the literal. This patch introduces validators which ensure that the string literal is a valid configuration value and return a meaningful error otherwise. Fixes redpanda-data#3081 (cherry picked from commit 0343702)
Add tests for topic creation requests that use unexpected literal values (e.g. `compression.type=foo`). (cherry picked from commit bac883a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from pull request: #4953.
Fixes #5658,