Tests: fix upgrade_test #5440
Merged
Tests: fix upgrade_test #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
previously approved these changes
Jul 12, 2022
Upgrade test started failing because older versions of redpanda don't support the partition_autobalancing_mode flag (that was added to default config instead of the deprecated enable_auto_rebalance_on_node_add flag. Looks like the only tests that need a non-default value are node_operations_fuzzy_test (that sets it explicitly) and scaling_up_test (where we explicitly set the value)..
|
Looks like I missed that |
Sometimes in cithe leader table doesn't get updated in a timely fashion, leading to sporadic partition_balancer_test failures, so looks like the timeout of 30 seconds needs to be increased.
|
There were also some failures of the new |
ajfabbri
approved these changes
Jul 13, 2022
|
Failed in e2e_topic_recovery_test (#5241), restarting... |
mmedenjak
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Upgrade test started failing because older versions of redpanda don't
support the
partition_autobalancing_modeflag (that was added to the defaultconfig instead of the deprecated
enable_auto_rebalance_on_node_addflag.Looks like the only tests that need a non-default value are
node_operations_fuzzy_test(that sets it explicitly anyway) andscaling_up_test(where we explicitly set the value).Fixes #5437
Release notes