tests: don't ignore shutdown hangs in failure injector #5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
added
the
ci-repeat-5
|
Giving this a 5x repeat of tests, in case the improved hang detection triggers often enough to be disruptive. |
vbotbuildovich
removed
the
ci-repeat-5
dlex
reviewed
Jul 28, 2022
Previously, a hang on SIGINT would be logged, but then the test would proceed with a node in this zombie state. Since shutdown hangs are always a bug, it is correct to fail the test as early as we can with the right reason, so just re-raise the exception instead of trying to proceed. Related: redpanda-data#5178
jcsp
force-pushed
the
issue-5178-raise-on-shutdown-hang
branch
from
ed64407
to
190a3a0
Compare
dotnwat
approved these changes
Jul 28, 2022
|
For the 5x repeats, checked that there were no failures related to this change ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Previously, a hang on SIGINT would be logged, but then
the test would proceed with a node in this zombie state.
Since shutdown hangs are always a bug, it is correct to fail
the test as early as we can with the right reason, so just
re-raise the exception instead of trying to proceed.
Related: #5178
UX changes
None
Release notes