Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: don't ignore shutdown hangs in failure injector #5677

Merged
merged 1 commit into from
Jul 28, 2022
Merged

tests: don't ignore shutdown hangs in failure injector #5677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/rptest/services/failure_injector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ def inject_failure(self, spec):
self._start_func(spec.type)(spec.node)
except Exception as e:
self.redpanda.logger.info(f"injecting failure error: {e}")
if spec.type == FailureSpec.FAILURE_TERMINATE and isinstance(
e, TimeoutError):
# A timeout during termination indicates a shutdown hang in redpanda: this
# is a bug and we should fail the test on it. Otherwise we'd leave the node
# in a weird state & get some non-obvious failure later in the test, such
# as https://github.com/redpanda-data/redpanda/issues/5178
raise
finally:
if spec.length is not None:
if spec.length == 0:
Expand Down